-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address GSHP fan unit bug #1877
base: master
Are you sure you want to change the base?
Conversation
@jmaguire1: Some of the verification tests are failing. I think the units are now right, but the cooling COP calculated is 6.86 in the example model. I think this is a pretty big change. The test is here:
Another failure is an additional 10 feet in the borefield depth per borehole, which I do not think is that big of a deal. |
@afontani: Yeah, it is indeed a much bigger deal than I thought, and suggests we would have been really substantially underestimating the impact of the fan/pump and doing net to gross calculations: For reference, this is the base-hvac-ground-to-air-heat-pump, with a nominal COP of 3.6 and EER of 16.6. Maybe it's worth talking to someone like Jeff Munk and being sure we're doing things as intended before making such a big change? I just worry we have some other issue here with such a large difference in results. I'd like to feel more confident we've definitely done this right and then not have to revisit this again. |
Note that it was originally 5.36 but decreased to 4.87 in the previous bugfix attempt; see here. |
Pull Request Description
This PR addresses some unit inconsistencies in the GSHP fan/pump equations. There seem to be some unit issues with these equations:
OpenStudio-HPXML/HPXMLtoOpenStudio/resources/hvac.rb
Lines 2023 to 2028 in 2f7c475
Unit issues:
power_f
andpower_p
have units of KW*h/BTU but is expected to be Wh/BTU in the EIR calculation.-power_f
and-power_p
are not unitless and need another unit conversion like in the first term of the equation.Checklist
Not all may apply:
EPvalidator.xml
) has been updatedopenstudio tasks.rb update_hpxmls
)HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run