Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address GSHP fan unit bug #1877

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

afontani
Copy link
Collaborator

@afontani afontani commented Nov 7, 2024

Pull Request Description

This PR addresses some unit inconsistencies in the GSHP fan/pump equations. There seem to be some unit issues with these equations:

# Fan/pump adjustments calculations
power_f = heat_pump.fan_watts_per_cfm * 400.0 / UnitConversions.convert(1.0, 'ton', 'Btu/hr') * UnitConversions.convert(1.0, 'W', 'kW') # 400 cfm/ton, result is in kW per Btu/hr of capacity
power_p = heat_pump.pump_watts_per_ton / UnitConversions.convert(1.0, 'ton', 'Btu/hr') * UnitConversions.convert(1.0, 'W', 'kW') # result is in kW per Btu/hr of capacity
cool_eir = (1 - UnitConversions.convert(power_f, 'Wh', 'Btu')) / UnitConversions.convert(heat_pump.cooling_efficiency_eer, 'Btu', 'Wh') - power_f - power_p
heat_eir = (1 + UnitConversions.convert(power_f, 'Wh', 'Btu')) / heat_pump.heating_efficiency_cop - power_f - power_p

Unit issues:

  1. The power_f and power_p have units of KW*h/BTU but is expected to be Wh/BTU in the EIR calculation.
  2. IER is supposed to be unitless and the terms -power_f and -power_p are not unitless and need another unit conversion like in the first term of the equation.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@afontani
Copy link
Collaborator Author

@jmaguire1: Some of the verification tests are failing. I think the units are now right, but the cooling COP calculated is 6.86 in the example model. I think this is a pretty big change. The test is here:

assert_in_epsilon(4.87, clg_coil.ratedCoolingCoefficientofPerformance, 0.01)
.

Another failure is an additional 10 feet in the borefield depth per borehole, which I do not think is that big of a deal.

@jmaguire1
Copy link
Collaborator

@afontani: Yeah, it is indeed a much bigger deal than I thought, and suggests we would have been really substantially underestimating the impact of the fan/pump and doing net to gross calculations:

image

For reference, this is the base-hvac-ground-to-air-heat-pump, with a nominal COP of 3.6 and EER of 16.6. Maybe it's worth talking to someone like Jeff Munk and being sure we're doing things as intended before making such a big change? I just worry we have some other issue here with such a large difference in results. I'd like to feel more confident we've definitely done this right and then not have to revisit this again.

@shorowit
Copy link
Contributor

I think the units are now right, but the cooling COP calculated is 6.86 in the example model. I think this is a pretty big change.

Note that it was originally 5.36 but decreased to 4.87 in the previous bugfix attempt; see here.

@shorowit shorowit added this to the 1.9.0 milestone Nov 12, 2024
@shorowit shorowit linked an issue Nov 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Geothermal fan/pump adjustment fix
3 participants